SY-1120 Server-Side Downsampling #836
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## rc #836 +/- ##
==========================================
+ Coverage 45.89% 46.63% +0.74%
==========================================
Files 1101 1102 +1
Lines 69787 68482 -1305
Branches 3553 3544 -9
==========================================
- Hits 32031 31939 -92
+ Misses 36699 35485 -1214
- Partials 1057 1058 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -117,6 +117,7 @@ class StreamerConfig { | |||
| public: | |||
| /// @brief the channels to stream. | |||
| std::vector<ChannelKey> channels; | |||
| int downsample_factor = 1; | |||
There was a problem hiding this comment.
Would be good to document this parameter.
| return dsResponse | ||
| } | ||
|
|
||
| func downsampleSeries(series telem.Series, factor int) telem.Series { |
There was a problem hiding this comment.
Will this function will panic or have unexpected behavior on series with variable length data types (JSON, string)? I think so.
There was a problem hiding this comment.
should I return an error if a channel of a variable length data type is being downsampled?
There was a problem hiding this comment.
I would downsample it. The delimiter for JSON and STRING data types is a newline character.
| return dsResponse | ||
| } | ||
|
|
||
| func downsampleSeries(series telem.Series, factor int) telem.Series { |
There was a problem hiding this comment.
I would downsample it. The delimiter for JSON and STRING data types is a newline character.
Feature Pull Request Template
Key Information
Description
Summary of changes:
downsample factorwhich defaults to 1.nmeans you retain everynthsample)Basic Readiness Checklist
Migrations
properly migrated to new formats.
properly migrated to new formats.
Additional Notes
Manual QA Additions
with necessary manual QA steps to test my change.
Breaking Changes
Please list any breaking changes to public or internal packages.
Reviwer Checklist